Move payload codec, encode, and decode calls to DataConverter helper methods #1305
+206
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 26, 2026
Member
There was a problem hiding this comment.
I like this change of moving the payload-to/from-payload encoding/decoding to the data converter now that we're going to do more than just codec application (will also do limit checking and external payload provider stuff).
Nothing blocking from my POV, but not approving so Python SDK owners can look/approve (cc @tconley1428 and @THardy98)
tconley1428
reviewed
Jan 26, 2026
tconley1428
reviewed
Jan 26, 2026
tconley1428
reviewed
Jan 26, 2026
| return await self.payload_codec.encode(payloads) | ||
|
|
||
| # Temporary shortcircuit detection while the _encode_* methods may no-op if | ||
| # a payload codec is not configured. Remove once those paths have more to them. |
Contributor
There was a problem hiding this comment.
Or potentially keep but extend logic to include those other things. If there is still a scenario where it does nothing.
tconley1428
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Move payload codec, encode, and decode calls to DataConverter helper methods.
Why?
Allow future changes to have a central place to extend the general notions of encoding and decoding in a unified place.
Checklist